Add fine time correction in ahdc reconstruction#763
Merged
baltzell merged 8 commits intoJeffersonLab:developmentfrom Jul 30, 2025
Merged
Add fine time correction in ahdc reconstruction#763baltzell merged 8 commits intoJeffersonLab:developmentfrom
baltzell merged 8 commits intoJeffersonLab:developmentfrom
Conversation
Collaborator
ftouchte
commented
Jul 28, 2025
ftouchte
commented
- Used timestamp et startTime
- Used wf type instead of raw hit cuts
ftouchte
requested review from
N-Plx,
baltzell,
drewkenjo,
efuchey,
gurjyan,
hauenst,
mathieuouillon,
mcontalb,
mpaolone,
raffaelladevita,
rafopar,
whit2333 and
zieglerv
as code owners
baltzell
reviewed
Jul 28, 2025
Collaborator
There was a problem hiding this comment.
Those string manipulations should be replaced with bit arithmetic.
Collaborator
Author
There was a problem hiding this comment.
very good idea! 👍
Collaborator
Author
|
updated |
baltzell
approved these changes
Jul 30, 2025
baltzell
force-pushed
the
add/fineTimeCorrection
branch
from
60f7632 to
1cb4522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.